Skip to content

lib,permission: fix dropping addon permission #64007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mawalu wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −0
Open

lib,permission: fix dropping addon permission #64007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/node_binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "node_errors.h"
#include "node_external_reference.h"
#include "node_url_pattern.h"
#include "permission/permission.h"
#include "util.h"

#include <string>
Expand Down Expand Up @@ -450,6 +451,8 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
return THROW_ERR_DLOPEN_DISABLED(
env, "Cannot load native addon because loading addons is disabled.");
}
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kAddon, "");

auto context = env->context();

Expand Down
38 changes: 38 additions & 0 deletions test/parallel/test-permission-drop-addons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Flags: --permission --allow-addons --allow-fs-read=*
'use strict';

const common = require('../common');
const { isMainThread } = require('worker_threads');

if (!isMainThread) {
common.skip('This test only works on a main thread');
}

const assert = require('assert');

let bindingPath;
try {
bindingPath = require.resolve(
`../addons/hello-world/build/${common.buildType}/binding`);
} catch (err) {
if (err.code !== 'MODULE_NOT_FOUND') {
throw err;
}
common.skip('addon not found');
}

function openAddon() {
process.dlopen({ exports: {} }, bindingPath);
}

assert.ok(process.permission.has('addon'));
openAddon();

process.permission.drop('addon');
assert.ok(!process.permission.has('addon'));
assert.throws(() => {
openAddon();
}, common.expectsError({
code: 'ERR_ACCESS_DENIED',
permission: 'Addon',
}));
Loading