Skip to content

ffi: fix float passing in libffi for riscv64#63976

Open
kxxt wants to merge 1 commit into
nodejs:mainfrom
kxxt:rv-float-ffi
Open

ffi: fix float passing in libffi for riscv64#63976
kxxt wants to merge 1 commit into
nodejs:mainfrom
kxxt:rv-float-ffi

Conversation

@kxxt

@kxxt kxxt commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

libffi was incorrectly passing floats as doubles on RISC-V. This PR applies the merged upstream fix (libffi/libffi#972) for the vendored copy of libffi since libffi appears to have a very long release cycle (last release was at 2025-08-02).

This fixes the following three new test failures caught in https://github.com/riscv-forks/node-riscv/actions/runs/27544719447/job/81437248188:

out/Release/node --experimental-ffi --expose-gc --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/kxxt/node-riscv/test/ffi/test-ffi-dynamic-library.js
out/Release/node --experimental-ffi --expose-internals --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/kxxt/node-riscv/test/ffi/test-ffi-shared-buffer.js
out/Release/node --experimental-ffi --expose-gc --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/kxxt/node-riscv/test/ffi/test-ffi-calls.js

CC @nodejs/platform-riscv64

I am testing this PR on riscv64 at https://github.com/riscv-forks/node-riscv/actions/runs/27756747452/job/82120430409?pr=4

@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jun 18, 2026
@kxxt
ffi: fix float passing in libffi for riscv64
5c9c976 
libffi was incorrectly passing floats as doubles on RISC-V.
This PR applies the merged upstream fix (libffi/libffi#972) for the
vendored copy of libffi since libffi appears to have a very long release
cycle (last release was at 2025-08-02).

This fixes the following three new test failures:

test/ffi/test-ffi-dynamic-library.js
test/ffi/test-ffi-shared-buffer.js
test/ffi/test-ffi-calls.js

Signed-off-by: Levi Zim <rsworktech@outlook.com>
@kxxt

kxxt commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

It appears that there is some problem with NixOS binary cache that causes CI to fail.

error: hash mismatch importing path '/nix/store/bl7rmhhsy7vjb9qm3jfwgqpv3cn7wfb1-openssl-3.6.2';
         specified: sha256:0nagwij5x8yi54380yw53xy1ksn9jclp98lxmizbqq6hgngqp553
         got:       sha256:1fypgxjwksn6kh2ig4fmaskfnflicjq60zf5il2s9nxblhkkvnww
error: path '/nix/store/bl7rmhhsy7vjb9qm3jfwgqpv3cn7wfb1-openssl-3.6.2' is required, but there is no substituter that can build it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kxxt @nodejs-github-bot