fs: handle cpSync copyDir filesystem errors#63971
Open
ChrisChan0668 wants to merge 1 commit into
Open
Conversation
The native fs.cpSync() copyDir fast path is used for recursive copies when no filter option is provided. Some std::filesystem calls in that path used throwing overloads instead of overloads that report failures through std::error_code. When directory iteration, path canonicalization, or file type checks failed, those C++ exceptions could bypass Node's normal error conversion. Instead of reporting a JavaScript exception that callers can catch, the process could terminate in the native layer. Use non-throwing std::filesystem overloads throughout the copyDir implementation and convert each failure with ThrowStdErrException. Also add a Windows regression test that denies access to a copied directory and verifies cpSync throws in the child process instead of aborting. Fixes: nodejs#63970 Signed-off-by: ChrisChan0668 <192564531+ChrisChan0668@users.noreply.github.com>
Author
|
Tests run locally on Windows:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native fs.cpSync() copyDir fast path is used for recursive copies when no filter option is provided. Some std::filesystem calls in that path used throwing overloads instead of overloads that report failures through std::error_code.
When directory iteration, path canonicalization, or file type checks failed, those C++ exceptions could bypass Node's normal error conversion. Instead of reporting a JavaScript exception that callers can catch, the process could terminate in the native layer.
Use non-throwing std::filesystem overloads throughout the copyDir implementation and convert each failure with ThrowStdErrException. Also add a Windows regression test that denies access to a copied directory and verifies cpSync throws in the child process instead of aborting.
Fixes: #63970