repl: handle dot commands syntax error for multiline inputs#63911
Open
SudhansuBandha wants to merge 3 commits into
Open
repl: handle dot commands syntax error for multiline inputs#63911SudhansuBandha wants to merge 3 commits into
SudhansuBandha wants to merge 3 commits into
Conversation
9279b81 to
8141b1d
Compare
8141b1d to
4fa9ef6
Compare
Update conditional logic to correctly handle dot commands in multiline REPL input Fixes: nodejs#63864 Refs: nodejs#63889 Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
30d239b to
738694b
Compare
avinashkamat48
left a comment
There was a problem hiding this comment.
This can treat ordinary JavaScript property access as a REPL dot command whenever the property name matches a command. For example, obj .help is valid JS member access with whitespace before the dot, but isDotCommandAfterWhitespace plus the regex will extract help and run the REPL help command instead of evaluating the expression. The multiline case should likely only recognize a dot command when the dot begins a logical input line after optional indentation. Please add a regression test for obj .help / obj .break staying as JavaScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63864
Refs: #63889
Update conditional logic to correctly handle dot commands in multiline REPL input