crypto: reject non-positive RSA modulus in certificates#63871
Open
builtbyashwin wants to merge 1 commit into
Open
crypto: reject non-positive RSA modulus in certificates#63871builtbyashwin wants to merge 1 commit into
builtbyashwin wants to merge 1 commit into
Conversation
If an RSA modulus is zero or negative, return undefined instead of attempting to convert it. This prevents issues with malformed certificates. Fixes: nodejs#63824
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an RSA modulus is zero or negative, return undefined instead of attempting to convert it. This prevents issues with malformed certificates.
Fixes: #63824