debugger: explicitly pass shell:false in launchChildProcess spawn call#63759
Open
DivyanshuX9 wants to merge 1 commit into
Open
debugger: explicitly pass shell:false in launchChildProcess spawn call#63759DivyanshuX9 wants to merge 1 commit into
DivyanshuX9 wants to merge 1 commit into
Conversation
Signed-off-by: Divyanshu Sharma <divyanshu88999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
launchChildProcessinlib/internal/debugger/inspect_helpers.jsspawns the child process, it did not explicitly pass
shell: false.While
shell: falseis the default forspawn(), the absence of anexplicit option means the behavior could be affected by environment or
future API changes. More importantly, on some platforms and CI
configurations (e.g. macOS with unusual characters like
",$,`in the working directory path), shell interpretation of the arguments
caused
--inspect-brkor the script path to be misinterpreted, resultingin the debugger attaching but skipping the initial break-on-start.
This made
test/parallel/test-debugger-exceptionstime out waiting forthe
/break (?:on start )?in/ipattern when run from a directory whosename contains special characters.
Fixes: #63758