Skip to content

test: mark SEA tests flaky on linux arm#63743

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:test-build-sea
Open

test: mark SEA tests flaky on linux arm#63743
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:test-build-sea

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Jun 4, 2026

The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky on
linux arm so intermittent CI failures do not block unrelated changes.

Refs:

The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky on
linux arm so intermittent CI failures do not block unrelated changes.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 4, 2026
@trivikr trivikr added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2026
Comment thread test/sea/sea.status

[$system==linux && $arch==arm]
# LIEF-based --build-sea can be killed on arm debug CI.
test-single-executable-application*: PASS, FLAKY
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the flakes only showed up in debug builds, this needs to take that into account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants