doc: clarify fromReadable() duck-typed contract - #63682
Merged
Merged
Conversation
Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
watilde
approved these changes
Jun 15, 2026
Collaborator
|
Landed in 6ed5783 |
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #63682 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: nodejs#63682 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Aug 3, 2026
Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: nodejs#63682 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #63682 Backport-PR-URL: #64675 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the documented duck-typed contract for
stream/iterfromReadable().The implementation removes its internal
readablelistener withoff()duringcleanup, so duck-typed readable inputs need to provide
off()in addition toread()andon().Source code:
node/lib/internal/streams/iter/classic.js
Line 195 in 9e58d9d