net: recognize bare IPv6 loopback addresses in isLoopback#63619
Open
watilde wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63619 +/- ##
==========================================
- Coverage 90.29% 90.29% -0.01%
==========================================
Files 730 730
Lines 234782 234784 +2
Branches 43953 43956 +3
==========================================
- Hits 211993 211988 -5
- Misses 14501 14506 +5
- Partials 8288 8290 +2
🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
May 28, 2026
Contributor
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
I believe this change is a valid patch. Can you update the PR description? And maybe add some cases to th eloopbackNot array like ::2 and 0:0:0:0:0:0:0:2 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.