debugger: defer probe pause handling until startup#63608
Open
trivikr wants to merge 1 commit into
Open
Conversation
Keep the initial --inspect-brk pause held until probe breakpoints are bound and probe mode explicitly releases the target. This prevents the generic pause handler from resuming user code before probes are ready. Refs: https://github.com/nodejs/node/actions/runs/26482141780/job/77981519238 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63608 +/- ##
==========================================
- Coverage 90.31% 90.31% -0.01%
==========================================
Files 730 730
Lines 234695 234711 +16
Branches 43966 43959 -7
==========================================
+ Hits 211972 211986 +14
- Misses 14432 14449 +17
+ Partials 8291 8276 -15
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race in debugger probe mode where the startup
--inspect-brkpause could be resumed before probe breakpoints were fully installed.
The generic
Debugger.pausedhandler resumes pauses that do not match aprobe breakpoint. During startup, that can include the initial
--inspect-brkpause.If it is resumed before
bindBreakpoints()finishes, a short target script can runpast the probe location and the probe session times out.
This change ignores pause events until probe startup has completed, so the
main setup flow remains responsible for releasing the target after
breakpoints are bound.
Refs: https://github.com/nodejs/node/actions/runs/26482141780/job/77981519238
Assisted-by: openai:gpt-5.5