debugger: await initialization after run and restart#63607
Open
trivikr wants to merge 2 commits into
Open
Conversation
Ensure the debugger CLI waits for post-connect initialization before resolving the run and restart commands. This prevents tests and users from observing a prompt before Runtime.runIfWaitingForDebugger() has released the new debuggee. Refs: nodejs#61762 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63607 +/- ##
==========================================
+ Coverage 90.29% 90.32% +0.02%
==========================================
Files 730 730
Lines 234695 234709 +14
Branches 43956 43963 +7
==========================================
+ Hits 211927 211993 +66
+ Misses 14494 14434 -60
- Partials 8274 8282 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a debugger CLI synchronization race after
runandrestart.Previously, these commands resolved once the inspector websocket connection
was established and
okwas printed. The debugger initialization that enablesdomains, restores breakpoints, and calls
Runtime.runIfWaitingForDebugger()was started from the
readyevent but not awaited.That allowed the REPL prompt to be displayed before the restarted debuggee had
actually been released from
--inspect-brkand reported the initial break. Inslow CI runs, this could make
parallel/test-debugger-run-after-quit-restarttime out while waiting for the initial break message.
This changes
runandrestartto await the same post-connect initializationpath before resolving.
Observed in:
https://github.com/nodejs/node/actions/runs/26499357103/job/78035468302
Refs: #61762
Assisted-by: openai:gpt-5.5