src: merge CreateEnvironment() overloads#63596
Open
addaleax wants to merge 1 commit into
Open
Conversation
23c5506 to
37016f3
Compare
CreateEnvironment() implementationsCreateEnvironment() overloads
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63596 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 730 730
Lines 234671 234662 -9
Branches 43946 43958 +12
=======================================
+ Hits 211965 211967 +2
Misses 14423 14423
+ Partials 8283 8272 -11
🚀 New features to boost your workflow:
|
legendecas
approved these changes
May 27, 2026
Member
|
The linter error should be fixed with #63598 landed on the main branch. Would you mind rebasing on top of the main branch? |
API-compatible, but ABI-breaking, so done separately from the original 3090def. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Member
Author
|
@legendecas Thank you, done! |
37016f3 to
a21167c
Compare
legendecas
approved these changes
May 27, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-compatible, but ABI-breaking, so done separately from the original 3090def.