Skip to content

src: fix ContextifyContext property definer interception result#63549

Open
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:vm-intercept-52634
Open

src: fix ContextifyContext property definer interception result#63549
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:vm-intercept-52634

Conversation

@legendecas
Copy link
Copy Markdown
Member

This fixes that when defining a property, a definer callback
like a proxy handler would be invoked twice when the property
is writable.

Fixes: #52634

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 24, 2026
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
@legendecas legendecas force-pushed the vm-intercept-52634 branch from 8baf29f to 3fb03c6 Compare May 24, 2026 21:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (1ddb754) to head (3fb03c6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_contextify.cc 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63549      +/-   ##
==========================================
+ Coverage   90.31%   90.33%   +0.01%     
==========================================
  Files         730      730              
  Lines      234161   234163       +2     
  Branches    43917    43924       +7     
==========================================
+ Hits       211486   211525      +39     
+ Misses      14408    14363      -45     
- Partials     8267     8275       +8     
Files with missing lines Coverage Δ
src/node_contextify.cc 82.04% <85.71%> (-0.56%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContextifyContext::PropertyDefinerCallback() never intercepts the request

2 participants