debugger,test: deflake resume failure test and add debug logs#63524
Open
joyeecheung wants to merge 1 commit into
Open
debugger,test: deflake resume failure test and add debug logs#63524joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
On slow CI, the outer Debugger.resume can be picked up in the same drain pass as the Debugger.evaluateOnCallFrame, while V8 still considers the context paused. In this case both resume calls may succeed and the process can continue running from the setInterval until the timeout. Accept both probe failure and timeout as valid to accommodate this flakiness. This patch also adds more debug logs to the probe mode to show more information in case it flakes again in the CI Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
gurgunday
approved these changes
May 23, 2026
atlowChemi
approved these changes
May 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63524 +/- ##
==========================================
+ Coverage 90.30% 90.31% +0.01%
==========================================
Files 730 730
Lines 234188 234206 +18
Branches 43919 43912 -7
==========================================
+ Hits 211478 211527 +49
+ Misses 14443 14402 -41
- Partials 8267 8277 +10
🚀 New features to boost your workflow:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slow CI, the outer Debugger.resume can be picked up in the same drain pass as the Debugger.evaluateOnCallFrame, while V8 still considers the context paused. In this case both resume calls may succeed and the process can continue running from the setInterval until the timeout. Accept both probe failure and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to show more information in case it flakes again in the CI
Fixes: #63505