stream: reject pull() reads on abort#63498
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Make pull() race pending source reads against the provided AbortSignal so aborting can reject a pending next() even when the source is waiting before yielding data. Fixes: nodejs#63497 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
77d3f55 to
9e427dd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63498 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 718 718
Lines 227920 227991 +71
Branches 42824 42835 +11
==========================================
+ Hits 205472 205524 +52
- Misses 14225 14240 +15
- Partials 8223 8227 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
stream/iterpull()so pending source reads are abort-aware.When
{ signal }is provided, a pending sourcenext()now rejects when thesignal aborts instead of waiting for the source to eventually yield.
The abort-aware wrapper returns the original source unchanged when no signal is
provided, so the normal no-signal path does not add an extra async iterator
layer.
The regression tests cover aborting while the source
next()is pending inboth the no-transform path and a transform pipeline.
Fixes: #63497
Assisted-by: openai:gpt-5.5