Skip to content

crypto: fix warnings in test_node_crypto.cc#63490

Open
MayaLekova wants to merge 1 commit into
nodejs:mainfrom
MayaLekova:warnings-cleanup-cctest
Open

crypto: fix warnings in test_node_crypto.cc#63490
MayaLekova wants to merge 1 commit into
nodejs:mainfrom
MayaLekova:warnings-cleanup-cctest

Conversation

@MayaLekova
Copy link
Copy Markdown
Contributor

Fix build warnings by casting the number literals to the size_t constants they are compared against.

Fix build warnings by casting the number literals to the size_t
constants they are compared against.

Signed-off-by: Maya Lekova <maya@igalia.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 22, 2026
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (3553a34) to head (977ae9d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63490      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.01%     
==========================================
  Files         718      718              
  Lines      227914   227914              
  Branches    42811    42819       +8     
==========================================
+ Hits       205435   205468      +33     
+ Misses      14248    14231      -17     
+ Partials     8231     8215      -16     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants