test: fix flaky watch-mode tests with atomic writes#63462
Open
mcollina wants to merge 1 commit into
Open
Conversation
Use atomic file writes (write to temp file then rename) instead of direct writeFileSync in watch-mode tests. writeFileSync is not atomic - it truncates the file before writing, creating a race window where the ESM loader can read an empty/partial file and produce SyntaxErrors. This fix affects: - test/sequential/test-watch-mode-worker.mjs - test/sequential/test-watch-mode.mjs Both now write to a temp file and rename atomically, eliminating the truncation race. The interval timing in the worker test is also aligned with the main test (2500ms) to reduce the race probability. Refs: nodejs#62275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use atomic writes (write to temp file then rename) instead of direct writeFileSync in watch-mode tests to eliminate the truncation race with the ESM loader.