http: emit error on aborted ServerResponse#63448
Open
trivikr wants to merge 3 commits into
Open
Conversation
Emit an error when a ServerResponse is closed after end() but before the finish event is emitted. Fixes: nodejs#50656 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Expect ECONNRESET when an HTTP response pipeline is closed before the response finish event is emitted.
Update HTTP tests that intentionally close the client connection to expect ECONNRESET from ServerResponse.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63448 +/- ##
==========================================
- Coverage 90.06% 90.03% -0.03%
==========================================
Files 714 714
Lines 225918 225930 +12
Branches 42734 42735 +1
==========================================
- Hits 203464 203422 -42
- Misses 14232 14281 +49
- Partials 8222 8227 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
ServerResponsesocket-close handling so an ended response thatnever emitted
finishis marked withECONNRESETand emitserrorbeforeclosewhen an error listener is present.A regression test covers the case where the request socket is destroyed before
a deferred
res.end(), which previously emitted onlyclose.Fixes: #50656
Assisted-by: openai:gpt-5.5