fs: fix glob case mismatch on Windows and MacOS#63446
Open
louiellan wants to merge 1 commit into
Open
Conversation
where the `exclude` option is case sensitive but the `pattern` is a case insensitive operation (on Windows and MacOS), thus results to any casing difference in matched list not to be filtered out and does not return the true casing of a matched directory / file Refs: nodejs#58991 Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #58991
fix matchers'
nocaseMagicOnlyoption where it makes any non-magical/literal pattern case-sensitive which results to:excludeoption case sensitive which shouldn't be on Windows and macOS,Could be
notable-changebecause i suspect since this bug has been out for a while, i expect that developers might had some sense that theexcludeoption has always been a case sensitive part of the fs.glob, regardless of the operating systems quirks on case-sensitivity file system