Skip to content

test_runner: fix nested rerun with t.test#63428

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-nested-rerun
Closed

test_runner: fix nested rerun with t.test#63428
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-nested-rerun

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented May 19, 2026

Fixes #63424

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 19, 2026

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 19, 2026
@MoLow
test_runner: fix nested rerun with t.test
744f4d6 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow force-pushed the fix-nested-rerun branch from 5976958 to 744f4d6 Compare May 19, 2026 10:46
@atlowChemi
Copy link
Copy Markdown
Member

atlowChemi commented May 19, 2026

@MoLow this breaks any existing .json file, no?

@atlowChemi
Copy link
Copy Markdown
Member

atlowChemi commented May 19, 2026

I think

node/doc/api/test.md

Lines 137 to 139 in 2ebf533

The key identifying a test in this map is the test file path, with the line and column where the test is defined.
in a case where a test defined in a specific location is run multiple times,
for example within a function or a loop,
is no longer accurate, with this change

@atlowChemi atlowChemi mentioned this pull request May 19, 2026
Open
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (4ee7567) to head (744f4d6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63428      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.01%     
==========================================
  Files         714      714              
  Lines      225876   225877       +1     
  Branches    42737    42742       +5     
==========================================
- Hits       203408   203387      -21     
- Misses      14244    14279      +35     
+ Partials     8224     8211      -13
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/rerun.js 92.40% <100.00%> (+0.19%) ⬆️
lib/internal/test_runner/test.js 97.02% <100.00%> (-0.01%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow
Copy link
Copy Markdown
Member Author

MoLow commented May 19, 2026

superseeded by #63431

@MoLow MoLow closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner's --test-rerun-failures could swallow actual failures on retries

4 participants

@MoLow @nodejs-github-bot @atlowChemi @benjamingr