Skip to content

test: fix typos in comments #63403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parkhojeong wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

test: fix typos in comments #63403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b0f9d
test: fix typo from funciton to function
parkhojeong May 18, 2026
3c702a1
test: fix typo from overriden to overridden
parkhojeong May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/client-proxy/test-http-set-global-proxy-from-env-override-fetch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ await checkProxiedFetch({
shutdown();
proxy2.close();

// Verify request did NOT go through original proxy, but the overriden one.
// Verify request did NOT go through original proxy, but the overridden one.
assert.deepStrictEqual(proxyLogs, []);

// FIXME(undici:4083): undici currently always tunnels the request over
Expand Down
2 changes: 1 addition & 1 deletion test/client-proxy/test-http-set-global-proxy-from-env-override-http.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ await checkProxiedRequest({
shutdown();
proxy2.close();

// Verify request did NOT go through original proxy, but the overriden one.
// Verify request did NOT go through original proxy, but the overridden one.
assert.deepStrictEqual(proxyLogs, []);

const expectedLogs = [{
Expand Down
2 changes: 1 addition & 1 deletion test/embedding/test-embedding-snapshot-vm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the vm-creating code in serialized main funciton.
// Build the snapshot with the vm-creating code in serialized main function.
spawnSyncAndExitWithoutError(
embedtest,
['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
Expand Down
2 changes: 1 addition & 1 deletion test/embedding/test-embedding-snapshot-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the worker-creating code in serialized main funciton.
// Build the snapshot with the worker-creating code in serialized main function.
spawnSyncAndExitWithoutError(
embedtest,
['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
Expand Down
Loading