http: remove unnecessary util._extend()#634
Closed
jonathanong wants to merge 1 commit into
Closed
Conversation
Contributor
|
LGTM so no need to use |
Member
|
The methods array is used inside the http parser guts. That's the reason it's cloned, because accidentally (or intentionally) modifying it is bound to break things. I would just leave it as it is. |
Contributor
Author
|
But sorting makes a clone... |
Member
|
Nuh-uh. :-) |
Contributor
Author
|
Waaaaaaa is it because no sorting took place? |
Contributor
|
No, |
Contributor
Author
|
@charmander agreed. updated |
Qard
pushed a commit
that referenced
this pull request
Feb 2, 2015
PR-URL: #634 Reviewed-BY: Nicu Micleușanu <micnic90@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Member
|
Landed in 3e67d7e |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on a mission to remove all instances of
util._extend()and I found this. AFAIK, this is unnecessary. 6100228#diff-1c0f1c434b17b7f8795d44a51a14320aR31/cc @bnoordhuis