Skip to content

test: keep finalization ref alive until exit #63394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Draft

test: keep finalization ref alive until exit #63394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/fixtures/process/different-registry-per-thread.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ const registeredRefs = [];
const ref = { foo: 'foo' };
registeredRefs.push(ref);

process.on('exit', () => {
// Keep `ref` strongly reachable until exit so the per-thread finalization
// callbacks are tested without depending on GC timing.
registeredRefs.length;
});

if (isMainThread) {
process.finalization.register(ref, () => {
process.stdout.write('shutdown on main thread\n');
Expand All @@ -13,7 +19,6 @@ if (isMainThread) {
const worker = new Worker(import.meta.filename);

worker.on('error', (err) => {
// Referencing `registeredRefs` here to avoid `ref` being GCed before the worker exits.
console.log(registeredRefs);
throw err;
});
Expand Down
Loading