assert: cap large assertion diffs#63379
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Author
|
Follow-up validation on the current head (
I also tried to produce a local patched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62792
Summary
Default assertion diff output now avoids running the Myers diff over very large inspected values. For non-
fulldiffs, if either inspected side has more than 1000 lines, the assertion error uses the existing truncated display path and marks the output as skipped.This keeps small assertion messages unchanged, while avoiding worse-than-linear behavior for cases like
assert.strictEqual(Buffer.alloc(n), [buffer])whereutil.inspect()expands each byte to a separate line.Benchmark
Using the patched
lib/internal/assert/assertion_error.jsthrough a targeted--expose-internalsharness on this checkout:A new benchmark case is included in
benchmark/assert/strict-equal-buffer-array.js.Tests
node --check lib/internal/assert/assertion_error.jsnode --check test/parallel/test-assert.jsnode --check benchmark/assert/strict-equal-buffer-array.jsgit diff --checkmake lint-js LINT_JS_TARGETS="lib/internal/assert/assertion_error.js test/parallel/test-assert.js benchmark/assert/strict-equal-buffer-array.js"Buffer.alloc(16000)I also ran
python3 configure.py --ninjasuccessfully. I startedninja -C out/Release node -j8, but stopped it because it was still compiling ICU at 236/4772 steps and had not reached a usableout/Release/nodebinary.