stream: avoid duplicate writes in toWritable#63360
Open
trivikr wants to merge 1 commit into
Open
Conversation
PushWriter can return false after accepting a chunk when block backpressure is active. Teach the classic Writable adapter to treat that case as accepted backpressure instead of retrying through the async write path. Fixes: nodejs#63359 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toWritable()currently treatswriteSync()/writevSync()returningfalseas meaning the data was not accepted and retries through the asyncwriter method.
For
PushWriterwithbackpressure: 'block',falsecan instead mean thechunk was accepted and backpressure is active. Retrying through
write()/writev()writes the same data twice.This updates the adapter to recognize that accepted-backpressure case and wait
for drain instead of retrying the chunk.
Fixes: #63359
Assisted-by: openai:gpt-5.5