Skip to content

src: cache continuation_data pointer in MKDirpSync#63335

Open
watilde wants to merge 3 commits into
nodejs:mainfrom
watilde:src/perfomance-improvement
Open

src: cache continuation_data pointer in MKDirpSync#63335
watilde wants to merge 3 commits into
nodejs:mainfrom
watilde:src/perfomance-improvement

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented May 15, 2026

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 15, 2026
watilde added 2 commits May 16, 2026 00:14
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
@watilde watilde force-pushed the src/perfomance-improvement branch from e0b8cdd to 9d973c7 Compare May 15, 2026 15:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.02%. Comparing base (f190a04) to head (f78194a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 77.77% 0 Missing and 2 partials ⚠️
src/stream_base.cc 92.85% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63335      +/-   ##
==========================================
- Coverage   90.04%   90.02%   -0.02%     
==========================================
  Files         714      714              
  Lines      225372   225367       -5     
  Branches    42606    42580      -26     
==========================================
- Hits       202931   202883      -48     
- Misses      14231    14270      +39     
- Partials     8210     8214       +4     
Files with missing lines Coverage Δ
src/node_file.cc 74.23% <77.77%> (+0.03%) ⬆️
src/stream_base.cc 81.22% <92.85%> (+0.93%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants