doc: clarify selected API behavior#63317
Open
MukundaKatta wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Comment on lines
+723
to
+728
| If a package wants to avoid the dual package hazard in Node.js while still | ||
| providing an ES module build for non-Node.js environments, consider using | ||
| `"node"` and `"default"` conditions instead. For example, the `"node"` | ||
| condition can point to a single CommonJS implementation for Node.js, while the | ||
| `"default"` condition points to an ES module implementation for browsers or | ||
| other JavaScript runtimes. |
Member
There was a problem hiding this comment.
Why is this being added? This should be its own PR.
Contributor
There was a problem hiding this comment.
+1, this PR should be split in 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed files
doc/api/fs.mddoc/api/globals.mddoc/api/packages.mdTests