Skip to content

crypto: fix unhandled error in Hash._transform #63261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haramj wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −1
Open

crypto: fix unhandled error in Hash._transform #63261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/crypto/hash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ Hash.prototype.copy = function copy(options) {
};

Hash.prototype._transform = function _transform(chunk, encoding, callback) {
this[kHandle].update(chunk, encoding);
if (!this[kHandle].update(chunk, encoding))
return callback(new ERR_CRYPTO_HASH_UPDATE_FAILED());
callback();
};

Expand Down
32 changes: 32 additions & 0 deletions test/parallel/test-crypto-hash-stream-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict';

// Flags: --expose-internals

const common = require('../common');
if (!common.hasCrypto) common.skip('missing crypto');

const assert = require('assert');
const crypto = require('crypto');
const { kHandle } = require('internal/crypto/util');

/**
* This test verifies that the Hash stream properly surfaces an error
* when the underlying native update fails.
*/

const h = crypto.createHash('sha256');

// Simulate native update failure by replacing the internal handle
const fakeHandle = {
update: () => false,
digest: () => Buffer.from('')
};

h[kHandle] = fakeHandle;

h.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_CRYPTO_HASH_UPDATE_FAILED');
}));

h.write('test data');
h.end();
Loading