Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test,tools: limit lint tolerance of gc global
Lint rules permitted the `gc` global in any test file. This change
limits it to just the files that need it.
  • Loading branch information
Trott committed Apr 28, 2016
commit c91423fa9e266a1a400fd7e923c757f9a0667fa7
3 changes: 0 additions & 3 deletions test/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@
rules:
## common module is mandatory in tests
required-modules: [2, "common"]

globals:
gc: false
1 change: 1 addition & 0 deletions test/addons/buffer-free-callback/test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose-gc
/* global gc:false */

require('../../common');
var binding = require('./build/Release/binding');
Expand Down
2 changes: 1 addition & 1 deletion test/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ var knownGlobals = [setTimeout,
global];

if (global.gc) {
knownGlobals.push(gc);
knownGlobals.push(global.gc);
}

if (global.DTRACE_HTTP_SERVER_RESPONSE) {
Expand Down
2 changes: 2 additions & 0 deletions test/gc/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
globals:
gc: false
1 change: 1 addition & 0 deletions test/parallel/test-http-parser-bad-ref.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// problem.

// Flags: --expose_gc
/* global gc:false */

require('../common');
var assert = require('assert');
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-vm-create-and-run-in-context.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose-gc
/* global gc:false */
require('../common');
var assert = require('assert');

Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-vm-run-in-new-context.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose-gc
/* global gc:false */

const common = require('../common');
const assert = require('assert');
Expand Down
1 change: 1 addition & 0 deletions test/pummel/test-net-connect-memleak.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose-gc
/* global gc:false */

var common = require('../common');
var assert = require('assert');
Expand Down
1 change: 1 addition & 0 deletions test/pummel/test-regress-GH-814.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose_gc
/* global gc:false */

function newBuffer(size, value) {
var buffer = Buffer.allocUnsafe(size);
Expand Down
1 change: 1 addition & 0 deletions test/pummel/test-regress-GH-814_2.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose_gc
/* global gc:false */

var common = require('../common');

Expand Down
1 change: 1 addition & 0 deletions test/pummel/test-tls-connect-memleak.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
// Flags: --expose-gc
/* global gc:false */

var common = require('../common');
var assert = require('assert');
Expand Down