Skip to content

test: reduce flakiness of different-registry-per-thread #63209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 11, 2026
+17 −4
Merged

test: reduce flakiness of different-registry-per-thread #63209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc9c902
test: reduce flakiness of `different-registry-per-thread`
aduh95 May 9, 2026
1a9791e
test: relax test-memory-usage arrayBuffers check
inoway46 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: reduce flakiness of different-registry-per-thread 
There was an assumption that the `WeakRef` would be kept alive but
it seems to not always be true on Windows. This commit makes sure
it's kept alive.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed May 9, 2026
commit fc9c9025530284292b29b7079d863fd1f6b94f86
15 changes: 13 additions & 2 deletions test/fixtures/process/different-registry-per-thread.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,26 @@
import { isMainThread, Worker } from 'node:worker_threads';

const registeredRefs = [];

const ref = { foo: 'foo' };
registeredRefs.push(ref);

if (isMainThread) {
process.finalization.register({ foo: 'foo' }, () => {
process.finalization.register(ref, () => {
process.stdout.write('shutdown on main thread\n');
});

const worker = new Worker(import.meta.filename);

worker.on('error', (err) => {
// Referencing `registeredRefs` here to avoid `ref` being GCed before the worker exits.
console.log(registeredRefs);
throw err;
});

worker.postMessage('ping');
} else {
process.finalization.register({ foo: 'bar' }, () => {
process.finalization.register(ref, () => {
process.stdout.write('shutdown on worker\n');
});
}
Loading