Skip to content

module: exclude node:ffi from builtinModules when flag is disabled #63158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 2 commits into from
May 6, 2026
Merged

module: exclude node:ffi from builtinModules when flag is disabled #63158

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999efeb
module: exclude node:ffi from builtinModules when flag is disabled
ljharb May 6, 2026
cc2a346
fixup! module: exclude node:ffi from builtinModules when flag is disa…
aduh95 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
module: exclude node:ffi from builtinModules when flag is disabled 
Module.builtinModules is supposed to only list modules
that are accessible to user code.
node:ffi requires --experimental-ffi to be required,
so filter it out when the flag is not set,
mirroring the existing handling for --experimental-quic.

Refs: #63137 (comment)

Signed-off-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@ljharb
ljharb committed May 6, 2026
commit 999efeba9258642dd85a1a544801f7218f21426f
3 changes: 3 additions & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,9 @@ function initializeCJS() {
if (!getOptionValue('--experimental-quic')) {
modules = modules.filter((i) => i !== 'node:quic');
}
if (!getOptionValue('--experimental-ffi')) {
modules = modules.filter((i) => i !== 'node:ffi');
}
Module.builtinModules = ObjectFreeze(modules);

initializeCjsConditions();
Expand Down
Loading