sea: add allowDynamicImportFromFileSystem config option#62771
Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Open
sea: add allowDynamicImportFromFileSystem config option#62771thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
86f8733 to
ff08042
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62771 +/- ##
==========================================
- Coverage 89.80% 89.66% -0.14%
==========================================
Files 699 706 +7
Lines 216363 218179 +1816
Branches 41370 41737 +367
==========================================
+ Hits 194309 195637 +1328
- Misses 14140 14450 +310
- Partials 7914 8092 +178
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit
allowDynamicImportFromFileSystemconfig option for SEA. When set totrue,import()from the injected main script can load modules from the file system. Default remains sealed (built-ins only), matching the current behavior.This enables the common SEA pattern where a small bootstrap hands off to a user entrypoint on disk via dynamic import.
Refs: #62726