Skip to content

[v24.x] src: add permission support to config file#62760

Open
marco-ippolito wants to merge 1 commit intonodejs:v24.x-stagingfrom
marco-ippolito:backport-config-stuff
Open

[v24.x] src: add permission support to config file#62760
marco-ippolito wants to merge 1 commit intonodejs:v24.x-stagingfrom
marco-ippolito:backport-config-stuff

Conversation

@marco-ippolito
Copy link
Copy Markdown
Member

PR-URL: #60746
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Pietro Marchini pietro.marchini94@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Apr 15, 2026
@marco-ippolito marco-ippolito force-pushed the backport-config-stuff branch from 6ad4758 to 03b4f6c Compare April 15, 2026 15:29
PR-URL: nodejs#60746
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@marco-ippolito marco-ippolito force-pushed the backport-config-stuff branch from 03b4f6c to 3f91afe Compare April 15, 2026 16:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (c989497) to head (3f91afe).
⚠️ Report is 264 commits behind head on v24.x-staging.

Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #62760      +/-   ##
=================================================
+ Coverage          90.06%   90.08%   +0.01%     
=================================================
  Files                672      673       +1     
  Lines             201174   202277    +1103     
  Branches           39304    39573     +269     
=================================================
+ Hits              181197   182226    +1029     
- Misses             12240    12259      +19     
- Partials            7737     7792      +55     
Files with missing lines Coverage Δ
src/node_options.cc 84.31% <ø> (+0.04%) ⬆️
src/node_options.h 97.88% <ø> (ø)

... and 148 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants