Skip to content

tools: improve backport review script #62573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 10, 2026
Merged

tools: improve backport review script #62573

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188dce4
tools: improve backport review script
aduh95 Apr 3, 2026
3790b50
fixup! tools: improve backport review script
aduh95 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: improve backport review script 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed Apr 3, 2026
commit 188dce4f950214b549ed24bcc9c25d4a5c639499
31 changes: 24 additions & 7 deletions tools/actions/review_backport.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,16 @@

BACKPORT_PR=$1

[ -x "$(command -v gh)" ] || {

Check failure on line 5 in tools/actions/review_backport.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/review_backport.sh:5:9: Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).
# shellcheck disable=SC2016
echo 'Missing required `gh` dependency' >&2
exit 1
}
[ -n "$BACKPORT_PR" ] || {
echo "Usage:"
echo 'tools/actions/review_backport.sh https://github.com/nodejs/node/pull/<backport-PR-number> | less'
echo 'DIFF_CMD="codium --wait --diff" tools/actions/review_backport.sh https://github.com/nodejs/node/pull/<backport-PR-number>'
echo "Limitations: This tools only supports PRs that landed as single commit, e.g. with 'commit-queue-squash' label."
echo "Usage:" >&2
echo 'tools/actions/review_backport.sh https://github.com/nodejs/node/pull/<backport-PR-number> | less' >&2
echo 'DIFF_CMD="codium --wait --diff" tools/actions/review_backport.sh https://github.com/nodejs/node/pull/<backport-PR-number>' >&2
echo "Limitations: This tools only supports PRs that landed as single commit, e.g. with 'commit-queue-squash' label." >&2

exit 1
}
Expand All @@ -15,16 +20,28 @@

set -ex

BACKPORT_PR_URL=$(gh pr view "$BACKPORT_PR" --json url --jq .url)

ORIGINAL=$(mktemp)
BACKPORT=$(mktemp)
trap 'set -x; rm -f "$ORIGINAL" "$BACKPORT"; set +x; trap - EXIT; exit' EXIT INT HUP

gh pr view "$BACKPORT_PR" --json commits --jq '.[] | map([ .oid, (.messageBody | match("(?:^|\\n)PR-URL: (https?://.+/pull/\\d+)(?:\\n|$)", "g") | .captures | last | .string)] | @tsv) | .[]' \
| while read -r LINE; do
COMMIT_SHA=$(echo "$LINE" | cut -f1)
PR_URL=$(echo "$LINE" | cut -f2)

curl -fsL "$PR_URL.diff" | sed "$SED_CMD" >> "$ORIGINAL"
curl -fsL "$BACKPORT_PR/commits/$COMMIT_SHA.diff" | sed "$SED_CMD" >> "$BACKPORT"
curl -fsL "$BACKPORT_PR_URL/commits/$COMMIT_SHA.diff" | sed "$SED_CMD" >> "$BACKPORT"
done

${DIFF_CMD:-diff} "$ORIGINAL" "$BACKPORT"
rm "$ORIGINAL" "$BACKPORT"
${DIFF_CMD:-diff} "$ORIGINAL" "$BACKPORT" || echo "diff command exited with $?" >&2

set +x

printf "Approve the PR using gh? [y/N] "
read -r r
[ "$r" != "y" ] || {
set -x
gh pr review "$BACKPORT_PR" --approve
}
Loading