Skip to content

http: add req.signal to IncomingMessage #62541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Apr 4, 2026
+153 −0
Merged

http: add req.signal to IncomingMessage #62541

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e265c6d
http: add req.signal to IncomingMessage
akshatsrivastava11 Apr 1, 2026
18f6103
test: add test for res.signal on client side http.request() response
akshatsrivastava11 Apr 2, 2026
b9a1333
http: initialize kAbortController to null instead of undefined
akshatsrivastava11 Apr 2, 2026
bdf63e1
http: remove abort listener and add test for server-side req.signal.a…
akshatsrivastava11 Apr 2, 2026
48d116f
doc: add message.signal to http IncomingMessage documentation
akshatsrivastava11 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: initialize kAbortController to null instead of undefined
  • Loading branch information
@akshatsrivastava11
akshatsrivastava11 committed Apr 2, 2026
commit b9a1333b3d3249ed93e1a269ee1b83119102474d
4 changes: 2 additions & 2 deletions lib/_http_incoming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function IncomingMessage(socket) {
// Flag for when we decide that this message cannot possibly be
// read by the user, so there's no point continuing to handle it.
this._dumped = false;
this[kAbortController] = undefined;
this[kAbortController] = null;
}
ObjectSetPrototypeOf(IncomingMessage.prototype, Readable.prototype);
ObjectSetPrototypeOf(IncomingMessage, Readable);
Expand Down Expand Up @@ -192,7 +192,7 @@ ObjectDefineProperty(IncomingMessage.prototype, 'signal', {
__proto__: null,
configurable: true,
get: function() {
if (this[kAbortController] === undefined) {
if (this[kAbortController] === null) {
const ac = new AbortController();
this[kAbortController] = ac;
if (this.destroyed) {
Expand Down