Skip to content

tools: respect 7 days wait commit-queue with one approval#62498

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:commit-queue-respect-1-reviewer
Closed

tools: respect 7 days wait commit-queue with one approval#62498
panva wants to merge 2 commits into
nodejs:mainfrom
panva:commit-queue-respect-1-reviewer

Conversation

@panva

@panva panva commented Mar 29, 2026

Copy link
Copy Markdown
Member

Respect 7 days wait time for commit-queue Add this label to land a pull request using GitHub Actions. PRs with only 1 approval.

In order to land, a pull request needs to be reviewed and [approved][] by
at least two Node.js Collaborators (one collaborator approval is enough if the
pull request has been open for more than 7 days)

This makes it so that the CQ label can be applied even with just one review and not end up with commit-queue-failed An error occurred while landing this pull request using GitHub Actions. because it lacks the second review.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 29, 2026
@panva panva requested review from aduh95 and jasnell March 29, 2026 18:45
@aduh95

aduh95 commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This will make the cron check every 5 minutes if that PR is ready, I’m not sure this is worth it. It’s also less than ideal that the seven days limit gets hard coded instead of relying on the NCU logic.

@panva

panva commented Mar 29, 2026

Copy link
Copy Markdown
Member Author
  1. cq doesn't run every 5 minutes despite its cron schedule
  2. it's not a big deal IMHO
  3. it doesn't bypass any logic, it's merely a convenience for something that has annoyed me and James for quite some time (based on our past discussion related to it)

@panva

panva commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

Alternatively I can check the ncu output string for this condition and skip based on that (rather than applying the failed label).

@aduh95

aduh95 commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

The alternatives I can think of:

  • introduce a new commit-queue-land-in-7-days or similar
  • make detection of "not-yet-ready PR"s easier on NCU side (e.g. exit with a specific exit code)

I think either (or both, we could actually combined them) would be a preferable approach – the latter in particular would also work for fast-track PRs, which has also been a pain

@panva panva closed this May 12, 2026
@panva panva deleted the commit-queue-respect-1-reviewer branch May 18, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants