Skip to content

stream: fix addAbortSignal() for web streams #62450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikeyan wants to merge 6 commits into
base: main
Choose a base branch
from
Open

stream: fix addAbortSignal() for web streams #62450

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac82063
stream: use internal abort hooks for web streams
ikeyan Mar 26, 2026
bb0c045
test: cover webstreams addAbortSignal regressions
ikeyan Mar 26, 2026
e65f320
stream: move webstream abort hooks onto prototypes
ikeyan Mar 29, 2026
ec81573
stream: minimize webstream abort hook behavior changes
ikeyan Mar 29, 2026
8242862
stream: reject TransformStream in addAbortSignal
ikeyan Mar 31, 2026
79df0f7
doc: update addAbortSignal webstream behavior
ikeyan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: update addAbortSignal webstream behavior
  • Loading branch information
@ikeyan
ikeyan committed Mar 31, 2026
commit 79df0f747d627760e72c1496cc4c7a89251d6cc7
10 changes: 9 additions & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3476,6 +3476,11 @@ readable.getReader().read().then((result) => {
<!-- YAML
added: v15.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/62450
description: For web streams, `addAbortSignal()` now runs `cancel` steps on
`ReadableStream`, and aborts `controller.signal` and runs
`abort` steps on `WritableStream`.
- version:
- v19.7.0
- v18.16.0
Expand All @@ -3493,7 +3498,10 @@ control stream destruction using an `AbortController`.

Calling `abort` on the `AbortController` corresponding to the passed
`AbortSignal` will behave the same way as calling `.destroy(new AbortError())`
on the stream, and `controller.error(new AbortError())` for webstreams.
on a Node.js stream. For web streams, it will error the stream with an
`AbortError`. For `ReadableStream`, it will then run the stream's cancel steps.
For `WritableStream`, it will abort `controller.signal` and then run the
stream's abort steps.

```js
const fs = require('node:fs');
Expand Down
Loading