Skip to content

deps: add perfetto sdk #62397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 3 commits into from
Closed

deps: add perfetto sdk #62397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31d9833
deps: add perfetto build files
legendecas Mar 22, 2026
52ed2f7
tools: add perfetto updater
legendecas Mar 22, 2026
efdce9a
deps: update perfetto to 54.0
legendecas Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: add perfetto updater
  • Loading branch information
@legendecas
legendecas committed Mar 22, 2026
commit 52ed2f7f29e4ab551d2681bba83073214e928267
7 changes: 7 additions & 0 deletions doc/contributing/maintaining/maintaining-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ This a list of all the dependencies:
* [ngtcp2][]
* [npm][]
* [openssl][]
* [perfetto][]
* [postject][]
* [simdjson][]
* [sqlite][]
Expand Down Expand Up @@ -353,6 +354,11 @@ the main openssl/openssl releases with the addition of APIs to support
the QUIC protocol.
See [maintaining-openssl][] for more information.

### perfetto

The [perfetto](https://github.com/google/perfetto) dependency is used to
generate performance traces for Node.js and V8.

### postject

The [postject](https://github.com/nodejs/postject) dependency is used for the
Expand Down Expand Up @@ -427,6 +433,7 @@ according to [RFC 8878](https://datatracker.ietf.org/doc/html/rfc8878).
[ngtcp2]: #ngtcp2
[npm]: #npm
[openssl]: #openssl
[perfetto]: #perfetto
[postject]: #postject
[simdjson]: #simdjson
[sqlite]: #sqlite
Expand Down
75 changes: 75 additions & 0 deletions tools/dep_updaters/update-perfetto.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
#!/bin/sh
set -e
# Shell script to update perfetto in the source tree to specific version

BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd)
DEPS_DIR="$BASE_DIR/deps"

[ -z "$NODE" ] && NODE="$BASE_DIR/out/Release/node"
[ -x "$NODE" ] || NODE=$(command -v node)

# shellcheck disable=SC1091
. "$BASE_DIR/tools/dep_updaters/utils.sh"

NEW_VERSION="$("$NODE" --input-type=module <<'EOF'
const res = await fetch('https://api.github.com/repos/google/perfetto/releases/latest',
process.env.GITHUB_TOKEN && {
headers: {
"Authorization": `Bearer ${process.env.GITHUB_TOKEN}`
},
});
if (!res.ok) throw new Error(`FetchError: ${res.status} ${res.statusText}`, { cause: res });
const { tag_name } = await res.json();
console.log(tag_name.replace('v', ''));
EOF
)"

CURRENT_VERSION=$(cat ./deps/perfetto/VERSION)

# This function exit with 0 if new version and current version are the same
compare_dependency_version "perfetto" "$NEW_VERSION" "$CURRENT_VERSION"

echo "Making temporary workspace"

WORKSPACE=$(mktemp -d 2> /dev/null || mktemp -d -t 'tmp')

cleanup () {
EXIT_CODE=$?
[ -d "$WORKSPACE" ] && rm -rf "$WORKSPACE"
exit $EXIT_CODE
}

trap cleanup INT TERM EXIT

PERFETTO_REF="v$NEW_VERSION"
PERFETTO_SDK_ZIP="perfetto-cpp-sdk-src.zip"

cd "$WORKSPACE"

echo "Fetching perfetto sdk archive"
curl -sL -o "$PERFETTO_SDK_ZIP" "https://github.com/google/perfetto/releases/download/$PERFETTO_REF/$PERFETTO_SDK_ZIP"

echo "Unpacking archive"
mkdir -p perfetto/sdk
unzip -d perfetto/sdk "$PERFETTO_SDK_ZIP"
rm "$PERFETTO_SDK_ZIP"
echo "$NEW_VERSION" > perfetto/VERSION
curl -sL -o "perfetto/LICENSE" "https://raw.githubusercontent.com/google/perfetto/refs/tags/$PERFETTO_REF/LICENSE"

# Remove C API headers. Only keep C++ API headers.
rm perfetto/sdk/perfetto_c.h perfetto/sdk/perfetto_c.cc

echo "Copying existing gyp files"
cp "$DEPS_DIR/perfetto/perfetto.gyp" "$WORKSPACE/perfetto"

echo "Copying existing GN files"
cp "$DEPS_DIR/perfetto/"*.gn "$DEPS_DIR/perfetto/"*.gni "$WORKSPACE/perfetto"

echo "Replacing existing perfetto"
rm -rf "$DEPS_DIR/perfetto"
mv "$WORKSPACE/perfetto" "$DEPS_DIR/"

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
finalize_version_update "perfetto" "$NEW_VERSION"