Skip to content

console: refactor to use rest params and template strings #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

console: refactor to use rest params and template strings #6233

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d068679
console: refactor to use rest params and template strings
jasnell Apr 15, 2016
328ae5f
Add concat to benchmark
jasnell Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add concat to benchmark
  • Loading branch information
@jasnell
jasnell committed Apr 19, 2016
commit 328ae5fde6084912e04ddf370215a1d7384c27bf
27 changes: 24 additions & 3 deletions benchmark/misc/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,20 @@ const v8 = require('v8');
v8.setFlagsFromString('--allow_natives_syntax');

var bench = common.createBenchmark(main, {
method: ['restAndSpread', 'argumentsAndApply', 'restAndApply'],
method: ['restAndSpread',
'argumentsAndApply',
'restAndApply',
'restAndConcat'],
concat: [1, 0],
n: [1000000]
});

const nullStream = createNullStream();

function usingRestAndConcat(...args) {
nullStream.write('this is ' + args[0] + ' of ' + args[1] + '\n');
}

function usingRestAndSpreadTS(...args) {
nullStream.write(`${util.format(...args)}\n`);
}
Expand Down Expand Up @@ -46,6 +53,16 @@ function optimize(method, ...args) {
method(...args);
}

function runUsingRestAndConcat(n) {
optimize(usingRestAndConcat, 'a', 1);

var i = 0;
bench.start();
for (; i < n; i++)
usingRestAndConcat('a', 1);
bench.end(n);
}

function runUsingRestAndSpread(n, concat) {

const method = concat ? usingRestAndSpreadC : usingRestAndSpreadTS;
Expand Down Expand Up @@ -89,11 +106,15 @@ function main(conf) {
runUsingRestAndSpread(n, conf.concat);
break;
case 'restAndApply':
runUsingRestAndApply(n);
runUsingRestAndApply(n, conf.concat);
break;
case 'argumentsAndApply':
runUsingArgumentsAndApply(n);
runUsingArgumentsAndApply(n, conf.concat);
break;
case 'restAndConcat':
if (conf.concat)
runUsingRestAndConcat(n);
break;
default:
throw new Error('Unexpected method');
}
Expand Down