Skip to content

test_runner: add context subtests expectFailure only skip todo #62263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakobJingleheimer wants to merge 5 commits into
base: main
Choose a base branch
from
+91 −2
Open

test_runner: add context subtests expectFailure only skip todo #62263

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e611323
test_runner: add context subtests `expectFailure` `only` `skip` `todo`
JakobJingleheimer Mar 15, 2026
d5e777d
fixup!: try `await`ing subtests
JakobJingleheimer Mar 15, 2026
db192c3
Revert "fixup!: try `await`ing subtests"
JakobJingleheimer Mar 15, 2026
6597499
remove over-complication to `runTest` signature
JakobJingleheimer Mar 28, 2026
bc3b228
fixup!: unbreak caller location
JakobJingleheimer Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fixup!: try awaiting subtests" 
This reverts commit d5e777d.
  • Loading branch information
@JakobJingleheimer
JakobJingleheimer committed Mar 15, 2026
commit db192c3d8cd3edb8e4476e6cbfcaa9802634e091
26 changes: 12 additions & 14 deletions test/parallel/test-runner-subtest-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,18 @@ test('subtest should return a promise', async (t) => {
});

test('t.test[variant]() should return a promise', async (t) => {
const xfail = t.test.expectFailure('expectFailure subtest', () => { throw new Error('This should pass'); });
const only = t.test.only('only subtest');
const skip = t.test.skip('skip subtest');
const todo = t.test.todo('todo subtest');

assert.ok(isPromise(xfail));
assert.ok(isPromise(only));
assert.ok(isPromise(skip));
assert.ok(isPromise(todo));

await xfail;
await only;
await skip;
await todo;
assert.ok(isPromise(
t.test.expectFailure('expectFailure subtest', () => { throw new Error('This should pass'); })
));
assert.ok(isPromise(
t.test.only('only subtest')
));
assert.ok(isPromise(
t.test.skip('skip subtest')
));
assert.ok(isPromise(
t.test.todo('todo subtest')
));
});

test('nested subtests should have test variants', async (t) => {
Expand Down