doc: clarify socket.setKeepAlive initialDelay arg#62171
Open
efekrskl wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
metcoder95
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Is it truncates or "rounds down to the nearest whole second" ?
Contributor
Author
There was a problem hiding this comment.
imo truncates is better as the behaviour would be same as Math.trunc() in this case. We also have examples for further clarification
Comment on lines
1406
to
1407
Contributor
There was a problem hiding this comment.
Suggested change
| For example, `setKeepAlive(true, 500)` does not update the delay because it is first converted to `0.5` and then truncated to `0`, leaving the value | |
| unchanged, while `setKeepAlive(true, 1500)` sets it to `1` second (converted to `1.5`, then truncated to `1`). |
I think something like this will be clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57712