Skip to content

src: release context frame in AsyncWrap::EmitDestroy #61995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Mar 3, 2026
+46 −3
Merged

src: release context frame in AsyncWrap::EmitDestroy #61995

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdd2d38
src: release context frame in AsyncWrap::EmitDestroy
Flarna Feb 25, 2026
2500801
Add DCHECK to ensure context_frame is not emtpy in MakeCallback
Flarna Feb 26, 2026
c458399
use undefined to avoid empty global
Flarna Feb 26, 2026
3b54b9a
set empty context_frame_, issue a process warning
Flarna Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use undefined to avoid empty global
  • Loading branch information
@Flarna
Flarna committed Feb 26, 2026
commit c4583995275a6af247413b14aa350fdb3b373c1b
3 changes: 2 additions & 1 deletion src/async_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ void AsyncWrap::EmitDestroy(bool from_gc) {
HandleScope handle_scope(env()->isolate());
USE(object()->Set(env()->context(), env()->resource_symbol(), object()));
}
context_frame_.Reset();
Isolate* isolate = env()->isolate();
context_frame_.Reset(isolate, Undefined(isolate));
}
}

Expand Down
Loading