Skip to content

http: tell the parser about CONNECT responses #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slushie wants to merge 3 commits into from
Closed

http: tell the parser about CONNECT responses #6198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adb1a96
http: tell the parser about CONNECT responses
slushie Apr 14, 2016
3c295e5
clean up tests to comply with some best practices
slushie Apr 15, 2016
08284b3
remove return value from .upgrade setter
slushie Apr 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove return value from .upgrade setter
  • Loading branch information
@slushie
slushie committed Apr 15, 2016
commit 08284b383f03079611498e5cee2475e57e12345c
2 changes: 0 additions & 2 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,6 @@ class Parser : public AsyncWrap {

bool upgrade = value->BooleanValue();
parser->parser_.upgrade = upgrade;

args.GetReturnValue().Set(value->ToBoolean());
}

protected:
Expand Down