Skip to content

crypto: always return certificate serial numbers as uppercase #61752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
+2 −2
Closed

crypto: always return certificate serial numbers as uppercase #61752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
crypto: always return certificate serial numbers as uppercase 
This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
  • Loading branch information
@addaleax
addaleax committed Feb 9, 2026
commit c2c84974be29c2f4b618f5fc67de867bdf79e781
4 changes: 2 additions & 2 deletions src/crypto/crypto_x509.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ MaybeLocal<Value> GetSignatureAlgorithmOID(Environment* env,

MaybeLocal<Value> GetSerialNumber(Environment* env, const X509View& view) {
if (auto serial = view.getSerialNumber()) {
return OneByteString(env->isolate(),
static_cast<unsigned char*>(serial.get()));
return ToV8Value(
env, ToUpper(std::string_view(static_cast<char*>(serial.get()))));
}
return Undefined(env->isolate());
}
Expand Down
Loading