Skip to content

src: fix --build-sea default executable path #61708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Feb 9, 2026
+35 −1
Merged

src: fix --build-sea default executable path #61708

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bff93ce
src: fix `--build-sea` default executable path
alexsch01 Feb 6, 2026
8b62eac
Add test
alexsch01 Feb 6, 2026
ebb070f
Cleanup after test
alexsch01 Feb 6, 2026
a756a12
use temp dir
alexsch01 Feb 6, 2026
d2f5377
fix lint
alexsch01 Feb 6, 2026
3e0ab1d
Apply suggestions from code review
alexsch01 Feb 7, 2026
94a3be0
Update test-build-sea-custom-argv0.js
alexsch01 Feb 7, 2026
bf058ae
Update test-build-sea-custom-argv0.js
alexsch01 Feb 7, 2026
6b6a27c
Apply suggestions from code review
alexsch01 Feb 7, 2026
643a70e
Update test-build-sea-custom-argv0.js
alexsch01 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_sea_bin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ ExitCode BuildSingleExecutable(const std::string& sea_config_path,

SeaConfig config = opt_config.value();
if (config.executable_path.empty()) {
config.executable_path = args[0];
config.executable_path = Environment::GetExecPath(args);
}

// Get file permissions from source executable to copy over later.
Expand Down
26 changes: 26 additions & 0 deletions test/sea/test-build-sea-custom-argv0.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
'use strict';
// This tests --build-sea with a custom argv0 value.

require('../common');

const { skipIfBuildSEAIsNotSupported } = require('../common/sea');

skipIfBuildSEAIsNotSupported();

const { resolve } = require('path');
const fixtures = require('../common/fixtures');
const { rmSync } = require('fs');

const { spawnSyncAndAssert } = require('../common/child_process');
const fixturesDir = fixtures.path('sea', 'basic');

spawnSyncAndAssert(
process.execPath,
['--build-sea', resolve(fixturesDir, 'sea-config.json')], {
cwd: fixturesDir,
argv0: 'argv0',
}, {
stdout: /Generated single executable/,
});

rmSync(resolve(fixturesDir, 'sea'));
Loading