Skip to content

lib: use bracket notation instead of String.prototype.startWith for locks #61492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jan 29, 2026
Merged

lib: use bracket notation instead of String.prototype.startWith for locks #61492

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16ead22
lib: use StringPrototypeStartsWith from primordials in locks
kimtaejin3 Jan 23, 2026
7176d5a
Apply suggestions from code review
kimtaejin3 Jan 24, 2026
bf9e8e8
Update lib/internal/locks.js
kimtaejin3 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@kimtaejin3 @ljharb
kimtaejin3 and ljharb authored Jan 24, 2026
commit 7176d5acfc2560ba1032385ab4f04fde0c719aa3
2 changes: 1 addition & 1 deletion lib/internal/locks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
PromisePrototypeThen,
PromiseResolve,
SafePromisePrototypeFinally,
StringPrototypeStartsWith,

Check failure on line 9 in lib/internal/locks.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'StringPrototypeStartsWith' is assigned a value but never used
Comment thread
kimtaejin3 marked this conversation as resolved.
Outdated
Symbol,
SymbolToStringTag,
} = primordials;
Expand Down Expand Up @@ -160,7 +160,7 @@
signal.throwIfAborted();
}

if (StringPrototypeStartsWith(name, '-')) {
if (name[0] === '-') {
// If name starts with U+002D HYPHEN-MINUS (-), then reject promise with a
// "NotSupportedError" DOMException.
throw lazyDOMException('Lock name may not start with hyphen',
Expand Down
Loading