Skip to content

http: implement slab allocation for HTTP header parsing #61375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Feb 4, 2026
Merged

http: implement slab allocation for HTTP header parsing #61375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20bde47
http: implement slab allocation for HTTP header parsing
mertcanaltin Jan 13, 2026
9115556
lint
mertcanaltin Jan 13, 2026
5def150
benchmark: add fragmented HTTP header parsing benchmark
mertcanaltin Jan 15, 2026
56393d3
implement shared slab allocation
mertcanaltin Jan 15, 2026
266bfdb
rename Allocate call
mertcanaltin Jan 21, 2026
b9090c9
optimize StringPtrAllocator memory management
mertcanaltin Jan 21, 2026
3d643fe
refactor StringPtr and Parser to use allocator parameter in Save and …
mertcanaltin Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize StringPtrAllocator memory management
  • Loading branch information
@mertcanaltin
mertcanaltin committed Jan 21, 2026
commit b9090c952343849d646176909f5091a8dcbfdde1
18 changes: 10 additions & 8 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,27 +129,29 @@ class StringPtrAllocator {
// Memory impact: ~8KB per parser (66 StringPtr × 128 bytes).
Comment thread
anonrig marked this conversation as resolved.
static constexpr size_t kSlabSize = 8192;

StringPtrAllocator() { buffer_.SetLength(0); }
StringPtrAllocator() = default;

// Allocate memory from the slab. Returns nullptr if full.
char* TryAllocate(size_t size) {
const size_t current = buffer_.length();
if (current + size > kSlabSize) {
if (length_ + size > kSlabSize) {
return nullptr;
}
buffer_.SetLength(current + size);
return buffer_.out() + current;
char* ptr = buffer_ + length_;
length_ += size;
return ptr;
}

// Check if pointer is within this allocator's buffer.
bool Contains(const char* ptr) const {
return ptr >= buffer_.out() && ptr < buffer_.out() + buffer_.capacity();
return ptr >= buffer_ && ptr < buffer_ + kSlabSize;
}

// Reset allocator for new message.
void Reset() { buffer_.SetLength(0); }
void Reset() { length_ = 0; }

private:
MaybeStackBuffer<char, kSlabSize> buffer_;
char buffer_[kSlabSize];
size_t length_ = 0;
};

struct StringPtr {
Expand Down
Loading