Skip to content

build: enable -DV8_ENABLE_CHECKS flag #61327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Jan 28, 2026
Merged

build: enable -DV8_ENABLE_CHECKS flag #61327

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53c7e04
build: enable -DV8_ENABLE_CHECKS flag
islandryu Jan 9, 2026
7cdc3a3
fix lint
islandryu Jan 9, 2026
3a222f8
fix set_configuration_variable_and_defines
islandryu Jan 10, 2026
6847a41
Update lib/util.js
islandryu Jan 10, 2026
ed19665
validate frameCount is an integer
islandryu Jan 10, 2026
8541332
use options.debug for branching
islandryu Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use options.debug for branching
  • Loading branch information
@islandryu
islandryu committed Jan 25, 2026
commit 8541332a76376fa1e4d3ca209463918bafd3fe77
29 changes: 5 additions & 24 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,17 +1627,6 @@ def set_configuration_variable(configs, name, release=None, debug=None):
configs['Release']['variables'][name] = release
configs['Debug']['variables'][name] = debug

def set_configuration_variable_and_defines(configs, name, release=None, debug=None, release_define=None, debug_define=None):
set_configuration_variable(configs, name, release, debug)
if configs['Debug'].get('defines') is None:
configs['Debug']['defines'] = []
if configs['Release'].get('defines') is None:
configs['Release']['defines'] = []
if debug_define:
configs['Debug']['defines'].append(debug_define)
if release_define:
configs['Release']['defines'].append(release_define)

def configure_arm(o):
if options.arm_float_abi:
arm_float_abi = options.arm_float_abi
Expand Down Expand Up @@ -1980,14 +1969,7 @@ def configure_library(lib, output, pkgname=None):


def configure_v8(o, configs):
set_configuration_variable_and_defines(
configs,
'v8_enable_v8_checks',
release='0',
debug='1',
release_define=None,
debug_define='V8_ENABLE_CHECKS',
)
set_configuration_variable(configs, 'v8_enable_v8_checks', release=0, debug=1)

o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
o['variables']['v8_enable_javascript_promise_hooks'] = 1
Expand Down Expand Up @@ -2618,11 +2600,10 @@ def make_bin_override():
del configurations['Release']['variables']
config_debug_vars = configurations['Debug']['variables']
del configurations['Debug']['variables']
output['conditions'].append(['build_type=="Release"', {
'variables': config_release_vars,
}, {
'variables': config_debug_vars,
}])
if options.debug:
variables = variables | config_debug_vars
else:
variables = variables | config_release_vars

# make_global_settings should be a root level element too
if 'make_global_settings' in output:
Expand Down
Loading