Skip to content

inspector: fix compressed responses #61226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubnogueira wants to merge 5 commits into from
Closed

inspector: fix compressed responses #61226

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b967c69
inspector: fix compressed responses
rubnogueira Dec 30, 2025
cc3f224
inspector: lint code
rubnogueira Dec 31, 2025
520e278
inspector: remove irrelevant code
rubnogueira Dec 31, 2025
06183cd
inspector: remove irrelevant file
rubnogueira Dec 31, 2025
061f1a2
inspector: fix tests and inline
rubnogueira Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
inspector: lint code
  • Loading branch information
@rubnogueira
rubnogueira committed Dec 31, 2025
commit cc3f224c547733a8a3d3b86155bea7bb77c01a6b
2 changes: 1 addition & 1 deletion lib/internal/inspector/network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function createDecompressor(encoding) {
* Decompresses a chunk of data based on the content encoding.
* @param {Buffer} chunk - The compressed data chunk.
* @param {string} encoding - The content encoding.
* @param {function} callback - Callback with (error, decompressedChunk).
* @param {Function} callback - Callback with (error, decompressedChunk).
*/
function decompressChunk(chunk, encoding, callback) {
const decompressor = createDecompressor(encoding);
Expand Down
1 change: 0 additions & 1 deletion lib/internal/inspector/network_http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const {
getNextRequestId,
registerDiagnosticChannels,
sniffMimeType,
getContentEncoding,
createDecompressor,
} = require('internal/inspector/network');
const { Network } = require('inspector');
Expand Down
2 changes: 2 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tools]
node = "24"
20 changes: 8 additions & 12 deletions test/parallel/test-inspector-network-http-compressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,34 +31,30 @@ const handleRequest = (req, res) => {
case '/gzip':
setResponseHeaders(res, 'gzip');
res.writeHead(200);
zlib.gzip(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.gzip(plainTextBody, common.mustSucceed((compressed) => {
res.end(compressed);
});
}));
break;
case '/deflate':
setResponseHeaders(res, 'deflate');
res.writeHead(200);
zlib.deflate(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.deflate(plainTextBody, common.mustSucceed((compressed) => {
res.end(compressed);
});
}));
break;
case '/br':
setResponseHeaders(res, 'br');
res.writeHead(200);
zlib.brotliCompress(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.brotliCompress(plainTextBody, common.mustSucceed((compressed) => {
res.end(compressed);
});
}));
break;
case '/zstd':
setResponseHeaders(res, 'zstd');
res.writeHead(200);
zlib.zstdCompress(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.zstdCompress(plainTextBody, common.mustSucceed((compressed) => {
res.end(compressed);
});
}));
break;
case '/plain':
setResponseHeaders(res);
Expand Down
20 changes: 8 additions & 12 deletions test/parallel/test-inspector-network-http2-compressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,34 +29,30 @@ const handleStream = common.mustCallAtLeast((stream, headers) => {
case '/gzip':
responseHeaders[http2.constants.HTTP2_HEADER_CONTENT_ENCODING] = 'gzip';
stream.respond(responseHeaders);
zlib.gzip(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.gzip(plainTextBody, common.mustSucceed((compressed) => {
stream.end(compressed);
});
}));
break;
case '/deflate':
responseHeaders[http2.constants.HTTP2_HEADER_CONTENT_ENCODING] = 'deflate';
stream.respond(responseHeaders);
zlib.deflate(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.deflate(plainTextBody, common.mustSucceed((compressed) => {
stream.end(compressed);
});
}));
break;
case '/br':
responseHeaders[http2.constants.HTTP2_HEADER_CONTENT_ENCODING] = 'br';
stream.respond(responseHeaders);
zlib.brotliCompress(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.brotliCompress(plainTextBody, common.mustSucceed((compressed) => {
stream.end(compressed);
});
}));
break;
case '/zstd':
responseHeaders[http2.constants.HTTP2_HEADER_CONTENT_ENCODING] = 'zstd';
stream.respond(responseHeaders);
zlib.zstdCompress(plainTextBody, (err, compressed) => {
if (err) throw err;
zlib.zstdCompress(plainTextBody, common.mustSucceed((compressed) => {
stream.end(compressed);
});
}));
break;
case '/plain':
stream.respond(responseHeaders);
Expand Down