Skip to content

repl: fix getters triggering side effects during completion #61043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Dec 20, 2025
Merged

repl: fix getters triggering side effects during completion #61043

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7108179
repl: fix getters triggering side effects during completion
dario-piotrowicz Dec 13, 2025
1f05135
improve code
dario-piotrowicz Dec 13, 2025
5615839
remove unnecessary string interpolation
dario-piotrowicz Dec 16, 2025
b6cb5c9
update type and name of `propName` argument
dario-piotrowicz Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update type and name of propName argument
  • Loading branch information
@dario-piotrowicz
dario-piotrowicz committed Dec 16, 2025
commit b6cb5c9fdfb8aca21e1a04e5f577670a78321347
8 changes: 4 additions & 4 deletions lib/internal/repl/completion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,21 +776,21 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
* whether its value is a proxy, to ensure that is the property does have a getter we don't end up
* triggering it when checking its value
* @param {any} obj The target object
* @param {string} propName The target property name
* @param {string | number | bigint | boolean | RegExp} prop The target property
* @param {(includes: boolean) => void} cb Callback that will be called with the result of the operation
* @returns {void}
*/
function propHasGetterOrIsProxy(obj, propName, cb) {
function propHasGetterOrIsProxy(obj, prop, cb) {
const propDescriptor = ObjectGetOwnPropertyDescriptor(
obj,
propName,
prop,
);
const propHasGetter = typeof propDescriptor?.get === 'function';
if (propHasGetter) {
return cb(true);
}

if (isProxy(obj[propName])) {
if (isProxy(obj[prop])) {
return cb(true);
}

Expand Down
Loading